[Common,PWGHF] Complete the charmed hypernuclei search and add light-nuclei track-quality cut to the skimming task #14390
+440
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of light nuclei in the skimming task
|
O2 linter results: ❌ 25 errors, |
github-actions
bot
changed the title
zhangbiao-phy
changed the title
fgrosa
reviewed
Jan 5, 2026
Collaborator
fgrosa
left a comment
fgrosa
left a comment
There was a problem hiding this comment.
Hi @zhangbiao-phy thanks a lot for the development! I still didn't check the full PR in detail, but I have a couple of important comments to be kept in mind
zhangbiao-phy
requested review from
a team,
NicoleBastid,
alibuild,
apalasciano,
ddobrigk,
deepathoms,
fcatalan92,
fcolamar,
gluparel,
hahassan7,
iarsene,
jgrosseo,
jpxrk,
ktf,
mfaggin,
mmazzilli,
stefanopolitano and
vkucera
as code owners
vkucera
requested changes
Jan 8, 2026
vkucera
reviewed
Jan 8, 2026
vkucera
reviewed
Jan 8, 2026
vkucera
reviewed
Jan 8, 2026
vkucera
reviewed
Jan 8, 2026
vkucera
reviewed
Jan 8, 2026
zhangbiao-phy
added a commit
to zhangbiao-phy/O2Physics
that referenced
this pull request
Jan 8, 2026
[PWGHF] Please consider the following formatting changes to AliceO2Group#14390
Collaborator
Author
|
hi @vkucera， could you take a look my commits for your comments? Thanks a lot |
vkucera
reviewed
Jan 15, 2026
| Configurable<bool> useIsQualityTrackITSForSoftPion{"useIsQualityTrackITSForSoftPion", true, "check qualityTracksITS status for soft pion tracks"}; | ||
| // proton PID, applied only if corresponding process function enabled | ||
| Configurable<LabeledArray<float>> selectionsPid{"selectionsPid", {hf_presel_pid::CutsPid[0], 5, 6, hf_presel_pid::labelsRowsPid, hf_presel_pid::labelsCutsPid}, "PID selections for proton / kaon / deuteron applied if proper process function enabled"}; | ||
| Configurable<LabeledArray<float>> selectionsPid{"selectionsPid", {hf_presel_pid::CutsPid[0], 7, 6, hf_presel_pid::labelsRowsPid, hf_presel_pid::labelsCutsPid}, "PID selections for proton / kaon / deuteron / triton /helium applied if proper process function enabled"}; |
Collaborator
There was a problem hiding this comment.
Don't hard-code the dimensions.
vkucera
reviewed
Jan 15, 2026
| constexpr int ChannelsTritonPid = ChannelsProtonPid::NChannelsProtonPid + 2; | ||
| constexpr int ChannelsHeliumPid = ChannelsProtonPid::NChannelsProtonPid + 3; | ||
| constexpr int NChannelsPidFor3Prong = static_cast<int>(ChannelsProtonPid::NChannelsProtonPid) + static_cast<int>(ChannelsKaonPid::NChannelsKaonPid) + static_cast<int>(ChannelsLightNucleiPid::NChannelsLightNucleiPid); | ||
| enum class ChannelsNucleiQA : int { |
Collaborator
There was a problem hiding this comment.
Suggested change
| enum class ChannelsNucleiQA : int { | |
| enum class ChannelsNucleiQA : int { |
Collaborator
Thanks for addressing my comments. I have added a couple more suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag @fgrosa for the informations